add System.PosixCompat.Process #6
Conversation
|
Thank you for the speedy review, @andreasabel. I've added a very simple test, though I'm not entirely sure what I could assert in it. |
ners
force-pushed
the
main
branch
2 times, most recently
from
c41084d to
42c0d02
Compare
|
@andreasabel apologies for the back-and-forth, I was hoping the CI would run automatically on PR. I've now discovered that I can enable CI actions on my own fork, so in the future I can test locally before opening a PR. 🙂 |
|
@andreasabel anything else to be done here or can we merge? |
src/System/PosixCompat/Process.hs
Outdated
|
|
||
| {-| | ||
| This module makes the operations exported by @System.Posix.Process@ | ||
| available on all platforms. On POSIX systems it re-exports operations from |
There was a problem hiding this comment.
I suppose this is a more a statement of intent than of actual function.
Currently, it only re-exports a single operation from System.Posix.Process.
Maybe it could be reformulated as This module intends to make the operations of @System.Posix.Process@ available on all platforms. What do you think?
There was a problem hiding this comment.
That sounds good; I’m in favour of iteratively improving the docs. Before the next version we could consider rewording the other modules as well.
|
Do you want this to be released asap or only eventually? |
|
Ideally I’d like version 0.7.1 sooner rather than later so I can update lsp-client. What I’d like to discuss afterwards is potentially refactoring the partially supported functions (e.g. the ones that throw exceptions on Windows) to a separate module in preparation for 0.8. |
|
I removed the Haskell warning for shadowing |
|
Released in 0.7.1. |
This PR adds the
getProcessIDfunction which is supported on both Unix and Win32 systems. It is already used bylsp-testandlsp-client.